Add values.schema.json

[ElijahQuinones]

What type of PR is this?

/kind feature

What is this PR about? / Why do we need it?

This PR adds the values.schema.json file. Allowing us to make sure changes to helm chart parameters also appear in the eks add-on version of the driver as long as it makes sense to do so.

How was this change tested?

❯ helm lint .
==> Linting .
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

Does this PR introduce a user-facing change?

Add values.schema.json to validate changes in values.yaml make it to the add-on schema.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from elijahquinones. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Code Coverage Diff

This PR does not change the code coverage

[torredil]

One suggested improvement, otherwise PR largely lgtm.

[torredil]

I was wondering why this diff exists (for the add-on, this section is defined as follows):

"priorityClassName": {
      "description": "Priority class for the Node Daemonset",
       "type": "string",
       "default": "system-node-critical"
},

Which is correct, because that default value is defined in the node template:

aws-ebs-csi-driver/charts/aws-ebs-csi-driver/templates/_node.tpl

Line 48 in b28e70d

priorityClassName: {{ .Values.node.priorityClassName | default "system-node-critical" }}

but is not currently set in values.yaml:

aws-ebs-csi-driver/charts/aws-ebs-csi-driver/values.yaml

Line 360 in b28e70d

priorityClassName:

I think this would be a good opportunity to fix that discrepancy.

[ElijahQuinones]

will do !

[AndrewSirenko]

/lgtm

Largely looks good to me, thank you!

The real test will be going through release process and merging with add-on.

[AndrewSirenko]

We're going to need to update our /hack/release-scripts/generate-sidecar-tags script to update default sidecar tags like this.

Can you add a backlog task for it or update the script?

[AndrewSirenko]

There is a typo here for guarantee. Did we run a spellcheck on this file? Your IDE should do this for you (or have a plugin).

[AndrewSirenko]

Can we run this file through a spellcheck? (Your IDE should do this for you)