-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover EFS FileSystemId instead of specifying it in storage class #1492
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: avanish23 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @avanish23. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
discovering efs with tags support add new mocks added mount_utils interface to the MockMounter discovering efs with single AWS call
b445adf
to
65af3c8
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What is this PR about? / Why do we need it?
This PR introduces the feature of discovering EFS FileSystemId instead of having to specify it in the SC parameters.
The way to use this feature is to create a storage class where the parameters have a new field
fileSystemDiscovery
.Currently, it takes 2 fields
creationToken
andtags
both being optional.creationToken is a string that takes the creation token of the EFS to be discovered as input
tags is a map of strings
Sample Storage Class
Note:
|
as it is a multi-line string inputWhat testing is done?
Unit tests added and current unit tests pass
Closes #1052