-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding metrics for request total, latency and size #177
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jie WU <[email protected]>
Signed-off-by: Jie WU <[email protected]>
Signed-off-by: Jie WU <[email protected]>
Signed-off-by: Jie WU <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: courageJ The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @courageJ. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -116,6 +119,7 @@ func (s *Server) HandleRequestBody(reqCtx *RequestContext, req *extProcPb.Proces | |||
}, | |||
}, | |||
} | |||
metrics.MonitorRequest(llmReq.Model, llmReq.ResolvedTargetModel, len(v.RequestBody.Body), time.Since(requestReceivedTimestamp)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't read through the PR but sharing this early feedback.
request start time: to be precise, this should be the first time when the Process
function is called, perhaps here
reqCtx := &RequestContext{} |
RequestContext
to store states for a request.
request end time: This needs to be the time after we finish processing the response body, potentially here:
resp, err = s.HandleResponseBody(reqCtx, req) |
[]string{"model_name", "target_model_name"}, | ||
) | ||
|
||
requestSizes = compbasemetrics.NewHistogramVec( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can have request_bytes
and request_tokens
to be clear about what size
means. In inference, number of tokens is an important metric we should have. It's OK to add as a follow up though. Just to make sure this is captured.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The PR adds the metrics handler and basic metrics for requests.