issue-639: Add labels from command line option to filestore backup resource #640
Conversation
k8s-ci-robot
added
release-note-none
|
Hi @bharath-b-rh. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
|
/cc @mattcary |
k8s-ci-robot
added
needs-rebase
|
IMO, this might just be considered a bug fix. |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
/retest pull-gcp-filestore-csi-driver-kubernetes-integration |
|
@bharath-b-rh: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-gcp-filestore-csi-driver-kubernetes-integration |
|
/test pull-gcp-filestore-csi-driver-e2e |
k8s-ci-robot
added
size/XL
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
/cc @mattcary Could you please help with the PR. |
|
/assign @leiyiz Leiyi, can you take a look and approve? |
| @@ -1678,6 +1735,7 @@ func TestCreateSnapshot(t *testing.T) { | |||
| Name: backupName, | |||
| Parameters: map[string]string{ | |||
| util.VolumeSnapshotTypeKey: "backup", | |||
| ParameterKeyLabels: "key1:value1", | |||
There was a problem hiding this comment.
I had injected the parameter to check a scenario in the existing test case. I have updated it by adding a new test case for label scenario.
pkg/csi_driver/controller_test.go
Outdated
| @@ -1591,6 +1624,30 @@ func TestCreateSnapshot(t *testing.T) { | |||
| }, | |||
| expectErr: true, | |||
| }, | |||
| { | |||
| name: "Parameters contain misconfigured labels", | |||
There was a problem hiding this comment.
can we be more specific on why the label is misconfigured
There was a problem hiding this comment.
suggestion incorporated. Other test case names are updated as well.
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-b-rh, leiyiz, pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.6 |
|
@bharath-b-rh: only kubernetes-sigs org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pwschuurman / @leiyiz Could you please help me with cherry picking this change to |
|
/cherry-pick release-1.6 |
|
@mattcary: new pull request created: #888 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds labels from command line option to the filestore backup resource. Adding this change would keep the labels behavior in uniform with what's supported for filestore instance resource.
Labels added by driver, user defined labels in StorageClass object and labels passed through command line are parsed with precedence in the listed order.
Which issue(s) this PR fixes:
Fixes #639
Special notes for your reviewer:
Does this PR introduce a user-facing change?: