-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppArmor Recorder: Add mkdir
hook
#2608
Conversation
Hi @mhils. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2608 +/- ##
==========================================
- Coverage 45.50% 41.38% -4.12%
==========================================
Files 79 109 +30
Lines 7782 18239 +10457
==========================================
+ Hits 3541 7549 +4008
- Misses 4099 10191 +6092
- Partials 142 499 +357 |
this otherwise generates a wall of text that hides compiler errors
for example, `ARGS='-run "TestSpoc/record/AppArmor/directories"'` can be used to only run a particular test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccojocar, mhils The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Did you use the same clang version like the CI to generate the eBPF bytecode? It looks like out of sync. |
/lgtm |
/lgtm |
It looks like |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR makes sure we properly record
mkdir
hooks.Which issue(s) this PR fixes:
None
Does this PR have test?
Yes.
Special notes for your reviewer:
Does this PR introduce a user-facing change?