Add ProviderConfig Controller #2792
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
2 times, most recently
from
8ca2383 to
64a3448
Compare
|
/retest |
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
from
64a3448 to
63b6cbe
Compare
|
/retest |
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
2 times, most recently
from
0c861ed to
fd75ee7
Compare
k8s-ci-robot
added
size/L
- Introduced a new ProviderConfigController to track ProviderConfig resources and start NEG controllers. - Added initialization and running the ProviderConfigController in multi-project mode in main.go.
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
from
fd75ee7 to
6fde296
Compare
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
from
6fde296 to
717f4c9
Compare
|
Thanks @panslava! I'm yet to take a look, but glancing through: now that we've started making use of our libraries/packages, are there some useful unit / integration tests that we can add? |
| workersNum = 5 | ||
| ) | ||
|
|
||
| type ProviderConfigController struct { |
There was a problem hiding this comment.
Please add a detailed comment regarding what this Controller does and it's responsibilities. Let's also add a very brief comment for the package (which likely is very similar, but very small)
| namer, | ||
| stopCh, | ||
| ) | ||
| if err != nil { |
There was a problem hiding this comment.
This seems to be checking for the incorrect error
|
|
||
| const multiProjectLeaderElectionLockName = "ingress-gce-multi-project-lock" | ||
|
|
||
| func StartWithLeaderElection( |
There was a problem hiding this comment.
Please add comments for the public functions.
| } | ||
| } | ||
|
|
||
| ctxConfig := ingresscontext.ControllerContextConfig{ |
There was a problem hiding this comment.
ctxConfig doesn't seem to be getting used?
|
|
||
| informersFactory := informers.NewSharedInformerFactoryWithOptions(kubeClient, ctxConfig.ResyncPeriod) | ||
|
|
||
| providerConfigInformer := providerconfiginformers.NewSharedInformerFactory(providerConfigClient, ctxConfig.ResyncPeriod).Flags().V1().ProviderConfigs().Informer() |
There was a problem hiding this comment.
Who starts this informer?
/assign @gauravkghildiyal
This will be the very last to review