Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update address.HoldExternal to allow holding IPv6 as well #2794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update address.HoldExternal to allow holding IPv6 as well #2794

wants to merge 1 commit into from

Conversation

TortillaZHawaii
Copy link
Contributor

This is done in order to reuse address holding logic in future mixed protocol NetLB IPv6 implementation. Similar thing has been already done in IPv4.

  • Updates config with fields that are IPv4/IPv6 specific.
  • Adds tests for HoldExternal IPv6 addresses.
  • Updates forwarding_rules_ipv6.go to use address.HoldExternal.
  • Removes tearDownResourcesWithWrongNetworkTier from l4netlb as it is already implemented inside address.HoldExternal.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 13, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @TortillaZHawaii. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 13, 2025
@TortillaZHawaii
Copy link
Contributor Author

/assign @mmamczur

@TortillaZHawaii TortillaZHawaii force-pushed the dwysocki-netlb-ipv6-hold-cp branch from 1faa992 to 0526702 Compare January 14, 2025 09:55
@TortillaZHawaii
Update address.HoldExternal to allow holding IPv6 as well
6dce545 
This is done in order to reuse address holding logic in future mixed protocol NetLB IPv6 implementation. Similar thing has been already done in IPv4.

* Updates config with fields that are IPv4/IPv6 specific.
* Adds tests for HoldExternal IPv6 addresses.
* Updates forwarding_rules_ipv6.go to use address.HoldExternal.
* Removes tearDownResourcesWithWrongNetworkTier from l4netlb as it is already implemented inside address.HoldExternal.
@TortillaZHawaii TortillaZHawaii force-pushed the dwysocki-netlb-ipv6-hold-cp branch from 0526702 to 6dce545 Compare January 14, 2025 10:05
@mmamczur
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmamczur, TortillaZHawaii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@k8s-ci-robot
Copy link
Contributor

@TortillaZHawaii: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress-gce-test 6dce545 link true /test pull-ingress-gce-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@TortillaZHawaii
Copy link
Contributor Author

/hold

It seems like there is some flakiness with the test.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@sawsa307 sawsa307 Awaiting requested review from sawsa307

Assignees

@mmamczur mmamczur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TortillaZHawaii @k8s-ci-robot @mmamczur