tests: use reconcile command for kOps 1.31+ #17152
Conversation
We expect people to start using the reconcile command particularly for upgrades.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| "${KOPS_B}" update cluster --admin --yes | ||
| # Verify no additional changes | ||
| "${KOPS_B}" update cluster | ||
| if [[ "${KOPS_VERSION_B}" =~ 1.3[123456789] ]]; then |
There was a problem hiding this comment.
maybe we should invert this, using the old method when the version matches 1.2 or 1.30. That way we avoid surprises when 1.40 is tested.
|
/retest |
|
Are there any plans to document the reconcile command better and in more detail? As a kOps user, I do not quite understand the relation of this command especially to the "upgrade cluster" command. As far as I understand, it does something like "if a rolling-update is required after an update, perform a rolling update now", is this right? But when do you run the single "kops reconcile cluster" command instead of "kops update cluster --reconcile" ? |
|
/test pull-kops-e2e-aws-upgrade-k130-ko130-to-klatest-kolatest-many-addons |
| "${KOPS_B}" update cluster | ||
| if [[ "${KOPS_VERSION_B}" =~ 1.3[123456789] ]]; then | ||
| # Preview changes | ||
| "${KOPS_B}" update cluster |
There was a problem hiding this comment.
Nit: Would be nice if kops reconcile cluster would show the same output as kops update cluster.
|
/override pull-kops-e2e-cni-flannel |
|
@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-cni-flannel In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
We expect people to start using the reconcile command
particularly for upgrades.