Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added podman package to Kubekins-e2e-v2 docker image, that is used in kubernetes-sigs/jobset #33955

Closed
wants to merge 1 commit into from

Conversation

epicseven-cup
Copy link
Contributor

This pull request is related to kubernetes-sigs/jobset#681 on jobset, where we want to use container engine to generate our python sdks.

This pull request is made to add podman into the image to prevent containers failing during testing process due to not having a container engine.

The owner of the Jobset are:

@ahg-g
@danielvegamyhre

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/images labels Dec 15, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @epicseven-cup!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @epicseven-cup. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: epicseven-cup
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Dec 16, 2024

/hold

let's not please add more to this image!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2024
@aojea
Copy link
Member

aojea commented Dec 16, 2024

we need to pin our dependencies and have a stable set of projects and versions we depend on, adding more combinations we'll generate instability in the CI and will be very difficult to maintain.

Checking the PR associated I can't find the reason why we need to support podman

@BenTheElder
Copy link
Member

We already support docker-in-docker, if you search: https://github.com/search?q=repo%3Akubernetes%2Ftest-infra+docker-in-docker+path%3A%2F%5Econfig%5C%2Fjobs%5C%2F%2F&type=code

You can find examples.

This image is already huge and maintaining container-in-container to be ~functional in a custom image is tricky (we're actually not doing everything ideally as-is).

Can you leverage the existing docker-in-docker support?

@BenTheElder
Copy link
Member

You have to:

  1. use runner.sh to wrap your process
  2. set the docker-in-docker preset
  3. add privileged to the pod

You can see other jobs in the repo doing this.

@epicseven-cup
Copy link
Contributor Author

Thank you so much for the help, I will set docker-in-docker preset and add the priviledged to the pod

@aojea
Copy link
Member

aojea commented Dec 17, 2024

oh, my bad, so the problem was that you were not aware that there was already a docker in docker functionality ... sorry, I thought it was trying to duplicate the functionality

@epicseven-cup
Copy link
Contributor Author

no worries! 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants