-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added podman package to Kubekins-e2e-v2 docker image, that is used in kubernetes-sigs/jobset #33955
Conversation
Welcome @epicseven-cup! |
Hi @epicseven-cup. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: epicseven-cup The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold let's not please add more to this image! |
we need to pin our dependencies and have a stable set of projects and versions we depend on, adding more combinations we'll generate instability in the CI and will be very difficult to maintain. Checking the PR associated I can't find the reason why we need to support podman |
We already support docker-in-docker, if you search: https://github.com/search?q=repo%3Akubernetes%2Ftest-infra+docker-in-docker+path%3A%2F%5Econfig%5C%2Fjobs%5C%2F%2F&type=code You can find examples. This image is already huge and maintaining container-in-container to be ~functional in a custom image is tricky (we're actually not doing everything ideally as-is). Can you leverage the existing docker-in-docker support? |
You have to:
You can see other jobs in the repo doing this. |
Thank you so much for the help, I will set docker-in-docker preset and add the priviledged to the pod |
oh, my bad, so the problem was that you were not aware that there was already a docker in docker functionality ... sorry, I thought it was trying to duplicate the functionality |
no worries! 😆 |
This pull request is related to kubernetes-sigs/jobset#681 on jobset, where we want to use container engine to generate our python sdks.
This pull request is made to add podman into the image to prevent containers failing during testing process due to not having a container engine.
The owner of the Jobset are:
@ahg-g
@danielvegamyhre