Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gate status for DisableNodeKubeProxyVersion #49343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix gate status for DisableNodeKubeProxyVersion #49343

wants to merge 1 commit into from
+9 −1

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jan 8, 2025

The gate was "deprecated" in v1.31 after several rounds of battles.

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 8, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tengqm. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit 2f005c3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67810f18a5ab0e00084655d2
😎 Deploy Preview https://deploy-preview-49343--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Jan 9, 2025
View reviewed changes
.../en/docs/reference/command-line-tools-reference/feature-gates/DisableNodeKubeProxyVersion.md Outdated
Comment on lines 13 to 14
- stage: beta
defaultValue: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this gate ever beta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.31.md
It was beta in 1.31.0, then reverted in 1.31.1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's list those patch version - the implementation allows that level of detail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this makes better sense.
Will try it anyway.

@tengqm
Fix gate status for DisableNodeKubeProxyVersion
2f005c3 
The gate was "deprecated" in v1.31 after several rounds of battles.
@tengqm tengqm force-pushed the fg-kubeproxyversion-132 branch from 3da2c95 to 2f005c3 Compare January 10, 2025 12:14
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@salaxander salaxander Awaiting requested review from salaxander

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengqm @k8s-ci-robot @sftim