Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ci): Merge Lint Check Workflows into a Single Workflow checks.yml #873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 33 additions & 27 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
@@ -1,35 +1,41 @@
name: Checks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usamaidrsk will you rename this workflow to meaningful title please. Checks doesn't give idea to contributors what exactly the check is about.

on:
pull_request:
types: [opened, synchronize]
pull_request:
types: [opened, synchronize]
push:
branches:
- '*'
paths-ignore:
- 'system/**/*'
- '.github/**/*'
- '*.md'

jobs:
checks:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16, 18, 20]
steps:
- name: Checkout Repo
uses: actions/checkout@v4
- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
checks:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16, 18, 20]
steps:
- name: Checkout Repo
uses: actions/checkout@v4

- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

- name: Setup and install deps
run: |
npm install
- name: Setup and install deps
run: npm install

- name: Lint check
run: npm run lint

- name: Prettier check
run: |
npm run format:check
- name: Prettier check
run: npm run format:check

- name: Build
run: |
npm run build
- name: Build
run: npm run build

- name: Test
run: |
npm run test
- name: Test
run: npm run test
34 changes: 0 additions & 34 deletions .github/workflows/lint.yml

This file was deleted.

Loading