Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AddAnyAttr trait for Static<V> #3464

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

geoffreygarrett
Copy link
Contributor

Closes: #3463

@geoffreygarrett
Copy link
Contributor Author

Hi, Is any further action required on my side?

@gbj
Copy link
Collaborator

gbj commented Jan 10, 2025

Thanks, this is an interesting approach that I can probably apply to the other string types as well. It has been very odd to me that the compiler couldn't figure this out -- thanks for fixing it.

No action needed, the CI failures are due to a change in cargo check behavior that I need to fix elsewhere.

@gbj gbj merged commit 7d9cd43 into leptos-rs:main Jan 10, 2025
69 of 74 checks passed
@geoffreygarrett geoffreygarrett deleted the feature/add-anyattr-static branch January 10, 2025 20:27
zakstucke pushed a commit to zakstucke/leptos that referenced this pull request Jan 21, 2025
* Implement AddAnyAttr trait for Static<V>

Closes leptos-rs#3463

* [autofix.ci] apply automated fixes

---------

Co-authored-by: geoffreygarrett <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement AddAnyAttr trait for Static<V>
2 participants