-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTGTest] Add representation for immediates #8053
base: main
Are you sure you want to change the base?
Conversation
8f01c9f
to
82ecbdc
Compare
1809c9e
to
305561c
Compare
82ecbdc
to
2f52c10
Compare
305561c
to
e099496
Compare
2f52c10
to
19ec825
Compare
e099496
to
5f5636f
Compare
19ec825
to
610f6c0
Compare
5f5636f
to
30f9e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a major reason to use this instead of wrapping an APInt?
This is supported naturally by elaboration while just wrapping an APInt requires some more custom handling in elaboration and my goal is to avoid custom handling in elaboration when possible. Basically, we need to know how to represent the elaborated version of the op and how to materialize it again.
To conclude, it's definitely possible to just wrap an APInt, but would that be more elegant than having a custom attribute? To me, this seemed more elegant, but let me know if you think otherwise. Alternatively, it'd also be possible to just use the builtin integer type for immediates which wouldn't require any additional handling in elaboration and also avoids this entire PR, but then it's less clear when you want to define an immediate and when, e.g., an upper bound for an |
30f9e93
to
483e9a0
Compare
No description provided.