Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: manually update PyTorch version #3727

Merged
merged 15 commits into from
Oct 18, 2024
Merged

build: manually update PyTorch version #3727

merged 15 commits into from
Oct 18, 2024

Conversation

vivekkhandelwal1
Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 commented Sep 24, 2024 •
edited
Loading

Set PyTorch and TorchVision version to nightly release 2024-10-15.

Tracker issue for the failing tests added to xfail_set in this PR. Issue: #3796

Signed-Off By: Vivek Khandelwal [email protected]

@vivekkhandelwal1
Copy link
Collaborator Author

vivekkhandelwal1 commented Oct 7, 2024 •
edited
Loading

@aartbik Many tests related to sparsity are failing while doing the PyTorch bump. What should I do? This bump has been pending for almost 2 weeks because of this.

Edit:

CC: @stellaraccident

@stellaraccident
Copy link
Collaborator

Disable and land: those features are not stable yet and the folks working on it know that they are on the hook to keep it working on a best effort basis.

@stellaraccident
Copy link
Collaborator

Did the shape expr test get fixed?

@vivekkhandelwal1
Copy link
Collaborator Author

Did the shape expr test get fixed?

Yeah, that's fixed.

@vivekkhandelwal1 vivekkhandelwal1 force-pushed the roll-pytorch branch 2 times, most recently from bcfb35c to 98961e1 Compare October 15, 2024 10:19
@vivekkhandelwal1 vivekkhandelwal1 mentioned this pull request Oct 15, 2024
Open
96 tasks
@vivekkhandelwal1
Copy link
Collaborator Author

I know a lot of tests have been added to the xfail_set but I have created a tracker issue here: #3796 for the same. I will work on those fixes, some of them are quick to fix which I will do probably in next few days, rest which might take longer can be kept for lower priority, if not needed urgently.

stellaraccident
stellaraccident reviewed Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Left some comments. I can triage today and land.

test/python/fx_importer/sparsity/sparse_test.py Show resolved Hide resolved
test/python/fx_importer/symbolic_shape_expr_test.py Outdated Show resolved Hide resolved
test/python/fx_importer/v2.3/mutation_import.py Outdated Show resolved Hide resolved
@vivekkhandelwal1
build: manually update PyTorch version
1eea6fe 
Set PyTorch and TorchVision version to nightly release 2024-10-06

Signed-Off By: Vivek Khandelwal <[email protected]>
@vivekkhandelwal1
Update filechecks for failing test
2d4d87c
@vivekkhandelwal1
Update torch version
b983142
@vivekkhandelwal1
This commit disables the failing sparse tensor tests since they are n…
b5ffb20 
…ot maintained

on day-to-day basis and blocks the roll PyTorch update for now.
@vivekkhandelwal1
Fix lint checks
a7e171f
@vivekkhandelwal1
Run test for specific torch version
a8f8afa
@vivekkhandelwal1
Fix lint check
aad34f8
@vivekkhandelwal1
Update PyTorch version
8d50d50
@vivekkhandelwal1
Disable some filechecks due to different IRs for stable and nightly v…
4dd4cbd 
…ersion
@vivekkhandelwal1
Update xfail set
bdfacf0
@vivekkhandelwal1
Update xfail set for Fx_Importer tests
128b7e3
@vivekkhandelwal1
Add more tests to xfail set
7df068d
@vivekkhandelwal1
Update abstract_interp_lib_gen.py
64f965a
@vivekkhandelwal1
Fix fx_importer tests
3319f4d
@vivekkhandelwal1
Copy link
Collaborator Author

Hi @stellaraccident, can you please re-review now?

I'm not sure if I have done the changes as you expect but I think that's the best effort from my side to get them working for both nightly and stable torch. Please let me know if I need to make any further changes.

stellaraccident
stellaraccident approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Couple of requests for comment in the review.

test/python/fx_importer/symbolic_shape_expr_test.py Show resolved Hide resolved
test/python/fx_importer/v2.3/mutation_import.py Show resolved Hide resolved
@vivekkhandelwal1 vivekkhandelwal1 merged commit 9c70676 into llvm:main Oct 18, 2024
3 checks passed
@vivekkhandelwal1 vivekkhandelwal1 deleted the roll-pytorch branch October 18, 2024 08:02
@aartbik
Copy link
Contributor

aartbik commented Dec 19, 2024

Disable and land: those features are not stable yet and the folks working on it know that they are on the hook to keep it working on a best effort basis.

Seeing this late due to my career change. But I am back ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellaraccident stellaraccident stellaraccident approved these changes

@aartbik aartbik Awaiting requested review from aartbik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vivekkhandelwal1 @stellaraccident @aartbik