Fix YouTube icon appearance with fill color #1037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added or changed iconsIcon X-rays
|
|
I'd rather not have multiple icon libraries unless I'm forced to, and it happens that I don't need more brand icons than Lucide offers at a time. I respect that no new icons are added, but I also fail to see the reason not to fix the old ones, no? :) |
|
Can we get this merged, pretty please? 🥺 |
|
Nope sorry we don't accept compound paths. These will nog work well in design programs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fill color was applied to YouTube icon, it appears as a rectangle with rounded corners, nothing more:
This PR fixes that by replacing polygon with second path added with
fill-rule="evenodd".The default appaerance remains unchanged. Before:
After (I swear it's a different screenshot 😆):