Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add play-square icon #1283

Merged
merged 3 commits into from
May 28, 2023
Merged

Add play-square icon #1283

merged 3 commits into from
May 28, 2023

Conversation

danielbayley
Copy link
Member

@danielbayley danielbayley commented May 16, 2023

Generic ‘play video’ icon, especially since https://lucide.dev/icon/youtube will be removed soon

@vercel
Copy link

vercel bot commented May 16, 2023

@danielbayley is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented May 16, 2023

Added or changed icons

icons/play-square.svg

Preview cohesion icons/arrow-up-square.svg
icons/play-square.svg
icons/leaf.svg
Preview stroke widths icons/play-square.svg
icons/play-square.svg
icons/play-square.svg
Icon X-rays icons/play-square.svg

Copy link
Member

@karsa-mistmere karsa-mistmere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@jguddas
Copy link
Member

jguddas commented May 17, 2023

A bit left heavy.

@danielbayley
Copy link
Member Author

danielbayley commented May 17, 2023

A bit left heavy.

@jguddas Maybe, but shifting it right 1px also looks off. The only other alternative being to shift it right by half a pixel, knocking it off-grid… Not sure that’s desirable?

Untitled

Artboard 1

Or, could stretch the shape/size of the triangle itself…

Untitled

Artboard 1

What do we think?

@karsa-mistmere
Copy link
Member

Yeah, being off grid is out of the question.

1st row: originals+PR
2nd row: shifted 1px to the right
3rd & 4th row: size bump proportional to play icon w/ & w/o added rounding as per #1043

image
image

@danielbayley
Copy link
Member Author

First or last row for me… I guess it’s dependent on #1043.

@jguddas
Copy link
Member

jguddas commented May 17, 2023

What about using circumcenter?

image

@karsa-mistmere
Copy link
Member

karsa-mistmere commented May 17, 2023

What about using circumcenter?

image

Well, if you can illustrate to me how exactly we would use this while also sticking to a 24px grid, then sure. 😄

(Bottom two rows are as close as humanly possible).

@jguddas
Copy link
Member

jguddas commented May 17, 2023

What about using circumcenter?
image

Well, if you can illustrate to me how exactly we would use this while also sticking to a 24px grid, then sure. 😄

Since when are we so strict on sticking to the grid, why not just make it align well even if it is not snapped to the grid?

@karsa-mistmere
Copy link
Member

Since when are we so strict on sticking to the grid, why not just make it align well even if it is not snapped to the grid?

It's always been and always will be a concern, because not sticking to the grid will result in blurry lines such as this:
image

@jguddas
Copy link
Member

jguddas commented May 17, 2023

Since when are we so strict on sticking to the grid, why not just make it align well even if it is not snapped to the grid?

It's always been and always will be a concern, because not sticking to the grid will result in blurry lines such as this: image

Ahh, good point, for this I don't think it's that bad.

That preview is super helpful, we should think about adding a preview like this to the PR comment.

@ericfennis ericfennis merged commit 36c53f9 into lucide-icons:main May 28, 2023
@danielbayley danielbayley deleted the play-square branch May 28, 2023 11:02
realguse pushed a commit to realguse/lucide that referenced this pull request Dec 25, 2024
* Improve `play` icon metadata

* Add `play-square` icon

* Update play-square.svg

---------

Co-authored-by: Karsa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants