ci: run tests on push to dev, main and all PRs
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmhtr
reviewed
Oct 5, 2024
| @@ -1,6 +1,12 @@ | |||
| name: tests | |||
|
|
|||
| on: push | |||
| on: | |||
There was a problem hiding this comment.
I think is better to run tests on every branch. We may have checks that prevent merges to master when tests fail but I think is better to know if they are failing in any other PR.
There was a problem hiding this comment.
I’m not sure I follow. This PR setup runs tests/checks on PRs targeting main and direct pushes to it. Are you suggesting we should also run tests on:
- PRs targeting any branch?
- Any commit pushed to any branch?
If that’s the case, there could be some downsides to consider:
- Duplicate test runs
- Increased resource usage
More notifications (added noise)not applicable
There was a problem hiding this comment.
Yeah, the problem is when developing an epic (the PRs would target a branch different from dev or master). I would let the rule to:
- Target any push in
devormain - Target any PR no matter the branch.
jcfranco
changed the title
jcfranco
changed the title
dev, main and all PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨🧪✨