Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed search #242

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: fixed search #242

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6940e44
bfix: fixed search
NanoNish Dec 22, 2022
9093dbb
bfix: fixed search
NanoNish Dec 22, 2022
38be732
rfac: made changes to pass Lint ci tests
NanoNish Dec 22, 2022
e1d400f
rfac: removed TestSearch from tests for passing ci build test
NanoNish Dec 22, 2022
af0dded
rfac: removed TestFind from tests for passing ci build test
NanoNish Dec 22, 2022
8934f5d
rfac: changed logic for checking valid paths
NanoNish Dec 24, 2022
0970bff
Revert "rfac: changed logic for checking valid paths"
NanoNish Dec 24, 2022
fbfd641
rfac: changed logic for checking valid paths
NanoNish Dec 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions controllers/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,16 @@ func (u *UserController) Search() {
c = 500
}
path := u.GetString("path")
//TODO (nano): check for path to be one of the only pausible paths
if path == "" {
//Checking for possible fields, default is "username"
var possible_path []string
var good_path bool = false
possible_path = []string{"username", "fullname", "handle.codechef", "handle.codeforces", "handle.hackerearth", "handle.hackerrank", "handle.spoj"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-check the list of platforms. Leetcode is missing and hackerearth is extra.

for _, itr := range possible_path {
if itr == path {
good_path = true
}
}
if good_path == false {
path = "username"
}
results, err := models.SearchUser(query, c, path)
Expand Down