fix:Go-VersionUpgrade to Go 1.23 #575 #577
Conversation
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
Signed-off-by: Swastik-Swarup-Dash <[email protected]>
Swastik-Swarup-Dash
force-pushed
the
go-update
branch
from
6229539 to
9460753
Compare
Swastik-Swarup-Dash
changed the title
Swastik-Swarup-Dash
changed the title
leecalcote
added
language/go
|
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check above. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
There was a problem hiding this comment.
This is missing an updated go.sum. Be sure that you have built the project, @Swastik-Swarup-Dash, and that it's functional.
|
|
||
| jobs: | ||
| golangci-lint: |
There was a problem hiding this comment.
you messed the indentation of this whole block of code. please restore it back
| @@ -2,86 +2,86 @@ name: Meshery-Operator CI | |||
|
|
|||
| on: | |||
| pull_request: | |||
| branches: [ master ] | |||
There was a problem hiding this comment.
no need for removing the space, you should leave the default behavior as it is and only change the number of Go version 1.21 => 1.23
check out this pr https://github.com/meshery/meshery-linkerd/pull/589/files
| @@ -2,9 +2,9 @@ name: Meshkit Error Codes Utility Runner | |||
| on: | |||
| push: | |||
| branches: | |||
| - 'master' | |||
| @@ -2,9 +2,9 @@ name: Meshkit Error Codes Utility Runner | |||
| on: | |||
| push: | |||
| branches: | |||
| - 'master' | |||
| - "master" | |||
| paths: | ||
| - '**.go' | ||
| - "**.go" |
| @@ -34,19 +34,19 @@ jobs: | |||
| commit_user_name: l5io | |||
| commit_user_email: [email protected] | |||
| commit_author: ${{ github.actor }} <${{ github.actor }}@users.noreply.github.com> | |||
| commit_options: '--signoff' | |||
There was a problem hiding this comment.
you shouldn't change the existing code
|
|
||
|
|
||
| GO_VERSION := 1.23 | ||
| export GO_VERSION |
There was a problem hiding this comment.
don't change the default behavior
Signed-off-by: Swastik Swarup Dash [email protected]
Go 1.21 -> Go 1.23