Disable oracle schema by default (#511)

Oracle is in conflict with the chat agent. Disable the schema by default. Also rename the setting to `schemaDefaultEnabled` to align terminology
microsoft · Dec 19, 2024 · 785f1a3 · 785f1a3
1 parent 4539e6b
commit 785f1a3
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/ts/packages/agentSdk/src/agentInterface.ts b/ts/packages/agentSdk/src/agentInterface.ts
@@ -27,7 +27,7 @@ export type SchemaManifest = {
 
 export type ActionManifest = {
     defaultEnabled?: boolean;
-    translationDefaultEnabled?: boolean;
+    schemaDefaultEnabled?: boolean;
     actionDefaultEnabled?: boolean;
     transient?: boolean; // whether the translator is transient, default is false
 

diff --git a/ts/packages/agents/oracle/src/oracleManifest.json b/ts/packages/agents/oracle/src/oracleManifest.json
@@ -1,6 +1,7 @@
 {
   "emojiChar": "🌀",
   "description": "Agent to produce oracular answers",
+  "schemaDefaultEnabled": false,
   "schema": {
     "description": "Oracle which gives mysterious answers",
     "schemaFile": "./oracleSchema.ts",

diff --git a/ts/packages/dispatcher/src/context/appAgentManager.ts b/ts/packages/dispatcher/src/context/appAgentManager.ts
@@ -368,7 +368,7 @@ export class AppAgentManager implements ActionConfigProvider {
                 "schemas",
                 name,
                 useDefault,
-                config.translationDefaultEnabled,
+                config.schemaDefaultEnabled,
                 record.schemas.has(name),
                 failedSchemas,
             );

diff --git a/ts/packages/dispatcher/src/translation/agentTranslators.ts b/ts/packages/dispatcher/src/translation/agentTranslators.ts
@@ -43,7 +43,7 @@ const debugConfig = registerDebug("typeagent:dispatcher:schema:config");
 export type ActionConfig = {
     emojiChar: string;
 
-    translationDefaultEnabled: boolean;
+    schemaDefaultEnabled: boolean;
     actionDefaultEnabled: boolean;
     transient: boolean;
     schemaName: string;
@@ -69,14 +69,14 @@ function collectActionConfigs(
     schemaName: string,
     emojiChar: string,
     transient: boolean,
-    translationDefaultEnabled: boolean,
+    schemaDefaultEnabled: boolean,
     actionDefaultEnabled: boolean,
 ) {
     transient = manifest.transient ?? transient; // inherit from parent if not specified
-    translationDefaultEnabled =
-        manifest.translationDefaultEnabled ??
+    schemaDefaultEnabled =
+        manifest.schemaDefaultEnabled ??
         manifest.defaultEnabled ??
-        translationDefaultEnabled; // inherit from parent if not specified
+        schemaDefaultEnabled; // inherit from parent if not specified
     actionDefaultEnabled =
         manifest.actionDefaultEnabled ??
         manifest.defaultEnabled ??
@@ -89,7 +89,7 @@ function collectActionConfigs(
             emojiChar,
             ...manifest.schema,
             transient,
-            translationDefaultEnabled,
+            schemaDefaultEnabled,
             actionDefaultEnabled,
         };
     }
@@ -106,7 +106,7 @@ function collectActionConfigs(
                 `${schemaName}.${subName}`,
                 emojiChar,
                 transient, // propagate default transient
-                translationDefaultEnabled, // propagate default translationDefaultEnabled
+                schemaDefaultEnabled, // propagate default schemaDefaultEnabled
                 actionDefaultEnabled, // propagate default actionDefaultEnabled
             );
         }