Irql.qll updates to expand ability to detect function IRQL requiremen…

…ts (#153) * updates to Irql.qll to add conditional macros within a _When_ macro * Update Irql.qll Signed-off-by: Jacob Ronstadt <[email protected]> * Update Irql.qll Signed-off-by: Jacob Ronstadt <[email protected]> * update IRQL library so that IRQL requirements for functions that are not annotated can be tracked by looking at the the functions implicit role type based on how it's used * Update Irql.qll to remove test code Signed-off-by: Jacob Ronstadt <[email protected]> * irql updates * bug fix in test script * Update build-codeql.yaml Signed-off-by: Jacob Ronstadt <[email protected]> * bug fix * bug fix --------- Signed-off-by: Jacob Ronstadt <[email protected]>
microsoft · Jan 6, 2025 · 3ef295d · 3ef295d
1 parent ece9421
commit 3ef295d
Show file tree

Hide file tree

Showing 10 changed files with 2,378 additions and 1,675 deletions.
diff --git a/.github/workflows/build-codeql.yaml b/.github/workflows/build-codeql.yaml
@@ -111,11 +111,11 @@ jobs:
     - name: Run test script
       shell: pwsh
       if: ${{ env.CONNECTION_STRING != '' }}
-      run: python src\drivers\test\build_create_analyze_test.py --codeql_path .\codeql-cli\codeql.exe --no_build --compare_results --connection_string "$env:CONNECTION_STRING" --share_name "$env:SHARE_NAME" --container_name "$env:CONTAINER_NAME"
+      run: python src\drivers\test\build_create_analyze_test.py --codeql_path .\codeql-cli\codeql.exe --no_build --compare_results --connection_string "$env:CONNECTION_STRING" --share_name "$env:SHARE_NAME" --container_name "$env:CONTAINER_NAME" -v
     - name: Run test script without compare
       shell: pwsh
       if: ${{ env.CONNECTION_STRING == '' }}
-      run: python src\drivers\test\build_create_analyze_test.py --codeql_path .\codeql-cli\codeql.exe --no_build 
+      run: python src\drivers\test\build_create_analyze_test.py --codeql_path .\codeql-cli\codeql.exe --no_build -v
 
 
   test-codeql-latest-vs-current:
@@ -173,7 +173,7 @@ jobs:
       uses: microsoft/setup-msbuild@v2
     - name: Run test script
       shell: pwsh
-      run: python src\drivers\test\build_create_analyze_test.py --codeql_path .\codeql-cli\codeql.exe --no_build --compare_results --connection_string "$env:CONNECTION_STRING" --share_name "$env:SHARE_NAME" 
+      run: python src\drivers\test\build_create_analyze_test.py --codeql_path .\codeql-cli\codeql.exe --no_build --compare_results --connection_string "$env:CONNECTION_STRING" --share_name "$env:SHARE_NAME" -v
 
   test-pack-version-update:
     runs-on: windows-latest

diff --git a/src/drivers/general/queries/IrqlIllegalValue/IrqlIllegalValue.sarif b/src/drivers/general/queries/IrqlIllegalValue/IrqlIllegalValue.sarif
@@ -66,7 +66,7 @@
                 "impact": "Insecure Coding Practice",
                 "kind": "problem",
                 "name": "Irql Illegal Value",
-                "opaqueid": "CQLD-TODO",
+                "opaqueid": "CQLD-C28151",
                 "owner.email:": "[email protected]",
                 "platform": "Desktop",
                 "precision": "medium",