Auto Hashing ID for VectorDB Classes (#4746) #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MongoDB ID None allow and pre made embeddings allow * tests for MongoDB change * Add support for generating hashed IDs for documents in vector databases * scaled back approach, removed embedding work, updated tests, single focus PR * Duplicate content search message and error adjustment.
|
Hi @ekzhu , could you help take a look at the failures? Those failures are not caused by the changes in this PR. |
|
@thinkall those failures are not caused by this PR, the web surfer tests are failing because the URL it used points to a live page which has been updated... |
|
@thinkall it's okay to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB ID None allow and pre made embeddings allow
tests for MongoDB change
Add support for generating hashed IDs for documents in vector databases
scaled back approach, removed embedding work, updated tests, single focus PR
Duplicate content search message and error adjustment.
Why are these changes needed?
To run openai tests for PR #4746 . @mattbeardey
Related issue number
Checks