Implement TLS 1.3 key schedule using crypto/hkdf #1472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLS 1.3 Key Schedule is normally not part of the FIPS boundary, but upstream Go decided to include it in the FIPS boundary to facilitate the FIPS 140-3 certification process.
The problem is that
crypto/internal/fips140/tls13
usescrypto/internal/fips140/hkdf
, which can't be patched to use other backends.To solve this problem, we created this package, which is a direct copy of crypto/internal/fips140/tls13, but uses
crypto/hkdf
instead ofcrypto/internal/fips140/hkdf
.I tried hard to move the
tls13
outside of the FIPS boundary without luck: https://go-review.googlesource.com/c/go/+/626836/comments/6e8e9eee_7a8fbce3.Fixes #1470.