Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spdk] Unrecognized option --without-isal #43442

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[spdk] Unrecognized option --without-isal #43442

wants to merge 2 commits into from
+8 −2

Conversation

ohhmm
Copy link

@ohhmm ohhmm commented Jan 23, 2025

No description provided.

@Mengna-Li Mengna-Li changed the title port spdk: Unrecognized option --without-isal [spdk] Unrecognized option --without-isal Jan 24, 2025
@Mengna-Li
Copy link
Contributor

@ohhmm Please upgrade port-version in spdk/vcpkg.json.

@Mengna-Li
Copy link
Contributor

Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@Mengna-Li Mengna-Li added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 24, 2025
@Mengna-Li Mengna-Li marked this pull request as draft January 24, 2025 02:23
@ohhmm ohhmm marked this pull request as ready for review January 24, 2025 07:45
Mengna-Li
Mengna-Li reviewed Jan 24, 2025
View reviewed changes
ports/spdk/CMakeLists.txt
@@ -17,7 +17,7 @@ IF (SOURCE_PATH)
SET(CMAKE_SOURCE_DIR ${SOURCE_PATH})
ENDIF ()

SET(SPDK_CONFIG --disable-tests --with-rdma --without-isal --with-dpdk=${CMAKE_SOURCE_DIR}/../../../spdk-dpdk/src/spdk-18.11-411c51fb97/build)
SET(SPDK_CONFIG --disable-tests --with-rdma --with-dpdk=${CMAKE_SOURCE_DIR}/../../../spdk-dpdk/src/spdk-18.11-411c51fb97/build)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why this option was removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unrecognized option by ./configure: build was failing with the option. Probably left from previous version by mistake

@Mengna-Li
Copy link
Contributor 

note: you can run the following commands to add the current version of spdk automatically:
  vcpkg x-add-version spdk
  git add versions
  git commit -m "Update version database"

@Mengna-Li Mengna-Li added the info:reviewed Pull Request changes follow basic guidelines label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mengna-Li Mengna-Li Mengna-Li approved these changes

Assignees

@Mengna-Li Mengna-Li

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohhmm @Mengna-Li