add basic support for simx #179
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this seems to be working fine but probably needs a bit more testing/polishing before merging.
adds basic simx support for the simulator. the new
./src/simfolder is for javascript that gets injected into the simulator iframe in addition to the stuff already injected by mkc. it's here that i added support for all of the frame spawning shenanigans.i didn't investigate, but it's possible that this code could be moved into pxt-mkc instead of the extension. the only thing that would need to be figured out is how to get the targetConfig.json sent to the simulator frame so that it can fetch the simx information; right now i proxy it from the vscode extension.