Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsb: small build improvements #237450

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Jan 8, 2025

  • tsb: normalize filenames consistently in add/removeScriptSnapshot
  • tsb: avoid processing css imports

cc @jrieken

Copy link

@AkiraYuki-04 AkiraYuki-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Return Consistency
Currently, the method returns the result of delete this._snapshots[filename], but if other deletions fail, this isn’t reflected. Instead, track and return the overall success:

@mjbvz mjbvz assigned jrieken and unassigned mjbvz Jan 8, 2025
@tmm1
Copy link
Contributor Author

tmm1 commented Jan 8, 2025

The return value is unused so I don't think it matters. The current implementation seems correct to me. The return value indicates whether a snapshot was present and deleted. The ancillary internal state is of no consequence to the caller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants