Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a profile for enforcing lightweight dependabot configuration #260

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Jan 8, 2025

The following PR adds a profile that would enforce a lightweight Dependabot configuration reflecting the ecosystem of the project.

It covers Go, Python and JavaScript. It also enables the github-actions by default.

Fixes: https://github.com/stacklok/minder-stories/issues/129

Depends on #227

@rdimitrov rdimitrov requested a review from a team as a code owner January 8, 2025 13:51
@rdimitrov rdimitrov self-assigned this Jan 8, 2025
@rdimitrov
Copy link
Member Author

I've tested this profile along another profile that has the dependabot_configured ruletype and they don't conflict, or at least not in a bad way.

For example, if the repo doesn't have dependabot enabled:

  • Both ruletypes will fail and if remediation is enabled, both will open PRs
  • Merging the enforce one, would satisfy both rules and the 2nd PR will be closed automatically by Minder
  • Merging the dependabot_configured one would not satisfy the enforce one and so only 1 of the rules will be satisfied leaving the other PR opened.

I consider this behaviour to be expected and not conflicting, but I'm open to discuss it of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants