Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgit2: Update to 1.9.0 #23050

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

libgit2: Update to 1.9.0 #23050

wants to merge 3 commits into from

Conversation

lazka
Copy link
Member

@lazka lazka commented Jan 9, 2025

No description provided.

@lazka lazka mentioned this pull request Jan 9, 2025
@ognevny ognevny force-pushed the libgit2-1.9.0 branch 2 times, most recently from 9c4c94b to cb0da9e Compare January 9, 2025 09:42
@ognevny
Copy link
Collaborator

ognevny commented Jan 9, 2025

pushed rebuilds, for most rust packages I removed libgit2 from depends. I'll wait for upstream repositories to update it and check whether tests pass (in some cases build fails)

@ognevny
Copy link
Collaborator

ognevny commented Jan 9, 2025

@lazka feel free to push fixes for non-rust packages if needed, here is the libgit2-glib fail

FAILED: libgit2-glib/libgit2-glib-1.0-0.dll.p/ggit-types.c.obj 
  "gcc" "-Ilibgit2-glib/libgit2-glib-1.0-0.dll.p" "-Ilibgit2-glib" "-I../libgit2-glib-1.2.0/libgit2-glib" "-I." "-I../libgit2-glib-1.2.0" "-ID:/M/msys64/mingw32/include/glib-2.0" "-ID:/M/msys64/mingw32/lib/glib-2.0/include" "-fdiagnostics-color=always" "-D_FILE_OFFSET_BITS=64" "-Wall" "-Winvalid-pch" "-ffast-math" "-fstrict-aliasing" "-Wpointer-arith" "-Wmissing-declarations" "-Wformat=2" "-Wstrict-prototypes" "-Wmissing-prototypes" "-Wnested-externs" "-Wold-style-definition" "-Wdeclaration-after-statement" "-Wunused" "-Wuninitialized" "-Wshadow" "-Wmissing-noreturn" "-Wmissing-format-attribute" "-Wredundant-decls" "-Wlogical-op" "-Wcast-align" "-Wno-unused-local-typedefs" "-Werror=implicit" "-Werror=init-self" "-Werror=main" "-Werror=missing-braces" "-Werror=return-type" "-Werror=array-bounds" "-Werror=write-strings" "-DG_DISABLE_CAST_CHECKS" "-DG_DISABLE_CHECKS" "-DTRANSLATE_WINDOWS_PATHS" "-march=pentium4" "-mtune=generic" "-O2" "-pipe" "-Wp,-D_FORTIFY_SOURCE=2" "-fstack-protector-strong" "-Wp,-D__USE_MINGW_ANSI_STDIO=1" "-DGIT_SSH=1" "-DG_LOG_DOMAIN=\"Ggit\"" -MD -MQ libgit2-glib/libgit2-glib-1.0-0.dll.p/ggit-types.c.obj -MF "libgit2-glib/libgit2-glib-1.0-0.dll.p/ggit-types.c.obj.d" -o libgit2-glib/libgit2-glib-1.0-0.dll.p/ggit-types.c.obj "-c" ../libgit2-glib-1.2.0/libgit2-glib/ggit-types.c
  In file included from D:/M/msys64/mingw32/lib/glib-2.0/include/glibconfig.h:9,
                   from D:/M/msys64/mingw32/include/glib-2.0/glib/gtypes.h:34,
                   from D:/M/msys64/mingw32/include/glib-2.0/glib/galloca.h:34,
                   from D:/M/msys64/mingw32/include/glib-2.0/glib.h:32,
                   from ../libgit2-glib-1.2.0/libgit2-glib/ggit-types.h:24,
                   from ../libgit2-glib-1.2.0/libgit2-glib/ggit-types.c:23:
  D:/M/msys64/mingw32/include/glib-2.0/glib/gmacros.h:872:31: error: static assertion failed: "Expression evaluates to false"
    872 | #define G_STATIC_ASSERT(expr) _Static_assert (expr, "Expression evaluates to false")
        |                               ^~~~~~~~~~~~~~
  ../libgit2-glib-1.2.0/libgit2-glib/ggit-types.c:27:27: note: in expansion of macro 'G_STATIC_ASSERT'
     27 | #define ASSERT_ENUM(a, b) G_STATIC_ASSERT (((int) a) == ((int) b))
        |                           ^~~~~~~~~~~~~~~
  ../libgit2-glib-1.2.0/libgit2-glib/ggit-types.c:253:1: note: in expansion of macro 'ASSERT_ENUM'
    253 | ASSERT_ENUM (GGIT_CHECKOUT_NONE,                    GIT_CHECKOUT_NONE);
        | ^~~~~~~~~~~
  D:/M/msys64/mingw32/include/glib-2.0/glib/gmacros.h:872:31: error: static assertion failed: "Expression evaluates to false"
    872 | #define G_STATIC_ASSERT(expr) _Static_assert (expr, "Expression evaluates to false")
        |                               ^~~~~~~~~~~~~~
  ../libgit2-glib-1.2.0/libgit2-glib/ggit-types.c:27:27: note: in expansion of macro 'G_STATIC_ASSERT'
     27 | #define ASSERT_ENUM(a, b) G_STATIC_ASSERT (((int) a) == ((int) b))
        |                           ^~~~~~~~~~~~~~~
  ../libgit2-glib-1.2.0/libgit2-glib/ggit-types.c:254:1: note: in expansion of macro 'ASSERT_ENUM'
    254 | ASSERT_ENUM (GGIT_CHECKOUT_SAFE,                    GIT_CHECKOUT_SAFE);
        | ^~~~~~~~~~~

@Biswa96
Copy link
Member

Biswa96 commented Jan 9, 2025

here is the libgit2-glib fail

you can try to copy-paste the patches from ArchLinux https://gitlab.archlinux.org/archlinux/packaging/packages/libgit2-glib/-/commit/8d396e2c0fc76c6d90c3a8f703e0e06d04cadf3f

@ognevny ognevny force-pushed the libgit2-1.9.0 branch 3 times, most recently from 554f0c6 to 07989e4 Compare January 9, 2025 14:09
@podsvirov
Copy link
Collaborator

podsvirov commented Jan 9, 2025

The pygit2 1.17.0 with support of libgit2 1.9.0 was released.

@ognevny
Copy link
Collaborator

ognevny commented Jan 9, 2025

thanks everyone, done

ognevny added a commit that referenced this pull request Jan 10, 2025
@ognevny
Copy link
Collaborator

ognevny commented Jan 10, 2025

kicad fails for CLANG64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants