Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[example] Update the CDN example to adapt React 19. #44979

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[example] Update the CDN example to adapt React 19. #44979

wants to merge 3 commits into from
+125 −2

Conversation

IceOfSummer
Copy link

@IceOfSummer IceOfSummer commented Jan 9, 2025 •
edited
Loading

Original example is not available on React 19:

Uncaught SyntaxError: The requested module 'react-dom' does not provide an export named 'createRoot'

Live preview:

@IceOfSummer
[examples] Support React19
ce0497c 
Signed-off-by: IceOfSummer <[email protected]>
@IceOfSummer
Create react-18-example.html
7fba67c 
Signed-off-by: IceOfSummer <[email protected]>
@IceOfSummer
Update README.md
297d4ca 
Signed-off-by: IceOfSummer <[email protected]>
@mui-bot
Copy link

mui-bot commented Jan 9, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44979--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 297d4ca

@zannager zannager added the examples Relating to /examples label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli Awaiting requested review from ZeeshanTamboli

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
examples Relating to /examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IceOfSummer @mui-bot @zannager