Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(iroh, iroh-relay): Avoid a duplicate tungstenite dependency (#3006
) ## Description Before we used to depend on both tungstenite version 0.21 as well as 0.24, because: ``` tungstenite v0.21.0 └── tokio-tungstenite v0.21.0 └── tokio-tungstenite-wasm v0.3.1 ├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh) └── iroh-relay v0.29.0 (/home/philipp/program/work/iroh/iroh-relay) ├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh) └── iroh-net-report v0.29.0 (/home/philipp/program/work/iroh/iroh-net-report) └── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh) tungstenite v0.24.0 └── tokio-tungstenite v0.24.0 ├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh) └── iroh-relay v0.29.0 (/home/philipp/program/work/iroh/iroh-relay) ├── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh) └── iroh-net-report v0.29.0 (/home/philipp/program/work/iroh/iroh-net-report) └── iroh v0.29.0 (/home/philipp/program/work/iroh/iroh) ``` Basically, `tokio-tungstenite-wasm` pulls in `0.21` and there's no newer version of it yet. But we updated all our dependencies including `tungstenite`, duplicating it. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> I want this to be temporary until we can finally switch to `fasterwebsockets` entirely once it implements [`poll`-based methods](denoland/fastwebsockets#78) (but I worry the project's maintenance is ... unclear). I checked the [tungstenite changelog](https://github.com/snapview/tungstenite-rs/blob/master/CHANGELOG.md), and it doesn't look like there's anything critical in there. The `rustls` update doesn't affect us - we don't duplicate rustls versions after this rollback. ## Change checklist - [x] Self-review. - [x] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant. - ~~[ ] Tests if relevant.~~ - [x] All breaking changes documented.
- Loading branch information