feat(core): Separate concurrency limits for production and evaluation executions (no-changelog) #12387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f concurrency limits
burivuhster
force-pushed
the
ai-520-impact-of-test-executions-on-concurrency-limits
branch
from
e467f5e to
fc9be62
Compare
n8n-assistant
bot
added
core
…rency-limits # Conflicts: # packages/cli/src/concurrency/concurrency-control.service.ts
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
ivov
reviewed
Jan 9, 2025
| @@ -35,6 +35,12 @@ export const schema = { | |||
| default: -1, | |||
| env: 'N8N_CONCURRENCY_PRODUCTION_LIMIT', | |||
| }, | |||
| evaluationLimit: { | |||
| doc: 'Max evaluation executions allowed to run concurrently.', | |||
There was a problem hiding this comment.
Let's add the other details as well? They all apply.
There was a problem hiding this comment.
I was not sure about the queue mode here, as the concurrency control service is disabled when n8n is being run in 'queue' mode. Isn't some different way to limit concurrency applies in queue mode for workers?
There was a problem hiding this comment.
In queue mode, concurrency control uses the exact same env but is delegated to Bull.
packages/editor-ui/src/components/executions/global/GlobalExecutionsList.vue
Show resolved
Hide resolved
packages/cli/src/concurrency/__tests__/concurrency-control.service.test.ts
Show resolved
Hide resolved
ivov
previously approved these changes
Jan 13, 2025
| */ | ||
| has(executionId: string) { | ||
| if (!this.isEnabled) return false; | ||
|
|
||
| return this.productionQueue.getAll().has(executionId); | ||
| return Array.from(this.queues.values()).some((queue) => queue.getAll().has(executionId)); |
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ai-520-impact-of-test-executions-on-concurrency-limits
|
| Run status |
|
| Run duration | 04m 50s |
| Commit |
|
| Committer | Eugene Molodkin |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
OlegIvaniv
approved these changes
Jan 14, 2025
|
|
|
✅ All Cypress E2E specs passed |
burivuhster
deleted the
ai-520-impact-of-test-executions-on-concurrency-limits
branch
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR separates concurrency limits for evaluation-related executions (both workflow under test and evaluation workflow executions) from existing production concurrency limits.
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)