fix(Postgres Chat Memory Node): Do not terminate the connection pool #12674
+1
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
changed the title
netroy
added
the
release/backport
despairblue
approved these changes
Jan 17, 2025
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
fix-MemoryPostgresChat
|
| Run status |
|
| Run duration | 04m 52s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
489
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
netroy
added a commit
that referenced
this pull request
Jan 17, 2025
netroy
added a commit
that referenced
this pull request
Jan 17, 2025
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jan 17, 2025
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jan 17, 2025
|
Got released with |
|
Validated using Great job, guys! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Postgres connection pools aren't managed in individual nodes now, and are instead managed in the
ConnectionPoolManager.When the Postgres Chat Memory node calls
pool.end(), it terminates the pool while theConnectionPoolManagerstill holds a reference to it. This leads to the Postgres Chat Memory node being completely broken until theConnectionPoolManagercleans up the reference to this pool. And if there are a lot of postgres calls on the instance, it's possible that the pool never gets cleaned up, and all postgres nodes using that specific credential are then broken indefinitely.Related Linear tickets, Github issues, and Community forum posts
Fixes #12517
https://linear.app/n8n/issue/NODE-2240
https://community.n8n.io/t/error-using-postgres-chat-memory-and-supabase-for-ai-tools-agent/70792
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)