compute: Build VM images suitable for lauching with neonvm-guest #10456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the slow recompilation of the docker layers, if some unrelated files are modified.
I don't see the point of that, postgres itself and many of the extensions are already built dynamically. The immediate reason to make the switch is that I intend to add the --with-systemd flag, and there don't seem to be a static version of that (at least not on Debian).
…guest The 'legacy-vm-builder-image' Dockerfile target can still be used to build an old-style VM image, for use with vm-builder. And that's still the default target. However, there are now ano other target, 'compute-node-bootable', that can be used to build an image that includes systemd unit files to launch the services, and 'compute-node-neonvm-payload' to package that as a QCOW2 image that can be used with the new neon-vm launcher. See neondatabase/autoscaling#1211 for the new launcher.
hlinnaka
force-pushed
the
wip-neonvm-payload
branch
from
dbe9e95 to
ed5efbd
Compare
7359 tests run: 6979 passed, 0 failed, 380 skipped (full report)Flaky tests (3)Postgres 17
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
ed5efbd at 2025-01-20T22:39:20.845Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'legacy-vm-builder-image' Dockerfile target can still be used to
build an old-style VM image, for use with vm-builder. And that's still
the default target. However, there are now ano other target,
'compute-node-bootable', that can be used to build an image that
includes systemd unit files to launch the services, and
'compute-node-neonvm-payload' to package that as a QCOW2 image that
can be used with the new neon-vm launcher.
See neondatabase/autoscaling#1211 for the new
launcher. That's a requirement for using the new-style images.