-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vectorstore instrumentation automation #1279
base: develop-tests
Are you sure you want to change the base?
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-tests #1279 +/- ##
================================================
Coverage ? 79.66%
================================================
Files ? 201
Lines ? 22173
Branches ? 3519
================================================
Hits ? 17664
Misses ? 3358
Partials ? 1151 ☔ View full report in Codecov by Sentry. |
_process_module_definition( | ||
"langchain_community.vectorstores.redis.base", | ||
"langchain_community.vectorstores.redis", | ||
"newrelic.hooks.mlmodel_langchain", | ||
"instrument_langchain_vectorstore_similarity_search", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not need the old hook too for backwards compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The location of these hooks did not actually move from previous versions. In the case of Redis and Docarray, there is an init.py file that imports these classes, so I'm just moving our hook for these vectorstores to be on the same level as the others.
This PR adds a new LangChain Vectorstore instrumentation populator to the
scripts
directory as well as some tweaks to the existing instrumentation.