Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: small edits to create-release-proposal workflow #56540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tools: small edits to create-release-proposal workflow #56540

wants to merge 1 commit into from
+4 −4

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 9, 2025

Those are basically nits, but here's a PR anyway:

  • Piping echo '{}' into jq is pure overhead, we can use --null-input/-n instead.
  • create-release.sh name is a bit misleading, it only creates a proposal, so IMO it makes sense to align with the workflow name.

@aduh95 aduh95 requested a review from a team as a code owner January 9, 2025 22:46
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/releasers

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jan 9, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @richardlau @RafaelGSS @marco-ippolito