-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency: Update to Prometheus 0.300.* #36873
base: main
Are you sure you want to change the base?
Conversation
The changes made to the scrape manager are a bit more involved than I expected. We'll need a new zap->slog adapter to replace the existing zap->go-kit adapter. Help appreciated because the solution was not immediately obvious to me 😬 |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@ArthurSens I think you can probably use the experimental adapter in the upstream zap repo: https://github.com/uber-go/zap/tree/master/exp |
TIL, thanks for the tip! I'll try it out in the next days |
b030e2e
to
7b03fac
Compare
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
…'s functions Signed-off-by: Arthur Silva Sens <[email protected]>
…xpandExternalLabels boolean Signed-off-by: Arthur Silva Sens <[email protected]>
7b03fac
to
bd40d67
Compare
Signed-off-by: Arthur Silva Sens <[email protected]>
This should be ready for review! cc @dashpole And I'm assuming we don't need a changelog entry, is that right? |
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
3bc3e87
to
f03944f
Compare
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
I wonder if the compliance test failures are related to Prometheus changing the default NameValidationScheme 🤔 |
receivers::prometheus: unknown scrape protocol , supported: [OpenMetricsText0.0.1 OpenMetricsText1.0.0 PrometheusProto PrometheusText0.0.4 PrometheusText1.0.0] Seems like the prometheus receivers' config validation changed? |
Ah, maybe be related to prometheus/prometheus#15136? The changelog says
|
yeah, we might need to set that in our default config |
The problem is that this is a per-scrape config, it looks like we can't just add that to global and that works for every scrape... or at least I'm missing some details somewhere |
Description
Supersedes #36642
This PR updates the prometheus/prometheus library in our go.mods to 0.300.* (which represents Prometheus 3.0).
It touches many go.mod files, but the Prometheus Receiver is the only component heavily affected by breaking changes.