[processor/k8sattributes] Wait for ReplicaSet informer before starting pod informer #37138
+29
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
requested review from
ChrsMark,
dmitryax,
fatsheep9146 and
TylerHelmuth
ChrsMark
reviewed
Jan 10, 2025
| // start the replicaSet informer first, as the replica sets need to be | ||
| // present at the time the pods are handled, to correctly establish the connection between pods and deployments | ||
| if c.Rules.DeploymentName || c.Rules.DeploymentUID { | ||
| waitForReplicaSets = true |
There was a problem hiding this comment.
Waiting for the ReplicaSet informer to sync before allowing Pod informer to sync make sense.
Should we consider waiting for other resources too before unblocking the Pod's sync?
I wonder if it is just cleaner to start all the informers in parallel except of the Pod informer, wait for them to sync and then start the Pod informer eventually ensuring that all the dependencies are in sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an alternative approach to the previous fix made for #37056, which did not fully solve the issue of the deployment name not being added to a pod after the initial informer sync
Link to tracking issue
Fixes #37056
Testing
Re-enabled the flaky E2E test