[chore] [exporter/elasticsearch] Extract datapoints into their own internal package #37237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
force-pushed
the
datapoints-package
branch
from
f2a7655 to
af44849
Compare
dmathieu
force-pushed
the
datapoints-package
branch
from
af44849 to
36b6349
Compare
dmathieu
force-pushed
the
datapoints-package
branch
from
51fbdaf to
71ec21d
Compare
crobert-1
approved these changes
Jan 24, 2025
|
|
||
| func histogramToValue(dp pmetric.HistogramDataPoint) (pcommon.Value, error) { | ||
| // Histogram conversion function is from | ||
| // https://github.com/elastic/apm-data/blob/3b28495c3cbdc0902983134276eb114231730249/input/otlp/metrics.go#L277 |
There was a problem hiding this comment.
Is there no alternative to duplicating the logic here? Is there any way to make the original functionality public? Would it be helpful to at least add a link in the histogramSample method that's being duplicated to update this method whenever it changes?
I see this method is simply being copied, no need to block this PR, just thought I'd call it out.
There was a problem hiding this comment.
Possibly. I'm improving the overall readability and separation of the module, and it's already causing frequent conflicts with other changes. So'id rather avoid mixing refactorings into it.
carsonip
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of the splitting of the elasticsearch exporter for a better separation of concerns.
It follows (and is currently based after) #37235.
This introduces a new datapoints package, so multiple mapping type packages can rely on them.