-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): extract translations on plugins
folder
#1589
base: master
Are you sure you want to change the base?
fix(i18n): extract translations on plugins
folder
#1589
Conversation
Thanks for the pull request, @igobranco! This repository is currently maintained by @openedx/2u-tnl. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
plugins
folderplugins
folder
@igobranco I added you to the triage team so tests will run automatically for you going forward. This PR seems to have stuck jobs, can you push an empty commit or similar to see if it kicks off the checks again? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1589 +/- ##
=======================================
Coverage 93.07% 93.07%
=======================================
Files 1092 1092
Lines 21617 21617
Branches 4577 4655 +78
=======================================
Hits 20120 20120
+ Misses 1431 1425 -6
- Partials 66 72 +6 ☔ View full report in Codecov by Sentry. |
Thanks @e0d |
fixes #1588
Description
This pull request fixes the extract translations process for the
plugins
folder.This increases the messages that are going to be extracted, making it possible to translate more of this application.
This PR is useful for "Operators" that use Studio and Course authoring MFE on a different language than English.
Testing instructions
Run the extract_translations on master and on this PR: