-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copyright examples #1407
Open
wesleytodd
wants to merge
1
commit into
openjs-foundation:main
Choose a base branch
from
wesleytodd:copyright-examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: copyright examples #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jan 10, 2025
erickzhao
approved these changes
Jan 10, 2025
bjohansebas
reviewed
Jan 10, 2025
ctcpip
reviewed
Jan 10, 2025
ctcpip
reviewed
Jan 10, 2025
ctcpip
reviewed
Jan 10, 2025
timmywil
approved these changes
Jan 10, 2025
UlisesGascon
approved these changes
Jan 11, 2025
mertcanaltin
approved these changes
Jan 11, 2025
bjohansebas
approved these changes
Jan 11, 2025
tobie
reviewed
Jan 11, 2025
tobie
reviewed
Jan 11, 2025
wesleytodd
force-pushed
the
copyright-examples
branch
from
January 20, 2025 15:57
cfeeea2
to
80d5783
Compare
erickzhao
approved these changes
Jan 20, 2025
tobie
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing my concerns and meeting me in the middle!
VoltrexKeyva
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some small examples and one clarifying line based on the conversation here: https://openjs-foundation.slack.com/archives/CS23BMK1P/p1736535381047589