Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tests that failed with tutorial #208

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Fixing tests that failed with tutorial #208

merged 4 commits into from
Dec 11, 2024

Conversation

ademDurakovic
Copy link
Collaborator

Fixing the tests that failed in the tutorial PR

Copy link
Collaborator

@rcAsironman rcAsironman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ademDurakovic Good work! However, I noticed some alignment issues on iOS. I've attached a screenshot below for reference. Additionally, we discussed adding a skip button, but I didn’t see it implemented. When a user clicks on the skip button, the onboarding tutorial should be bypassed.

Screenshot 2024-12-06 at 11 08 23 AM

Copy link
Collaborator

@rcAsironman rcAsironman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;

@rcAsironman rcAsironman merged commit 36b37da into main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants