-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Updated about to connect all members to their github profiles" #74
base: main
Are you sure you want to change the base?
Conversation
@kungfuchicken Please review the PR and let me know your comments. Thanks. |
Is this part of the react component dev work and conversting the page to MDX? I would expect the component to handle the link as well as the profile image. |
@kungfuchicken I created an MDX file that handles the profiles into several components. If available, the profile images are picked from the static folder; otherwise, the GitHub images are picked from the users' GitHub accounts. Please review. |
This approach is functional, but will not scale or adapt well as roles change. Having a generic component for |
I also want to keep the text for each person in the MDX file rather than moving it to the component. I'd prefer the component focus on a single concern, creating a styled profile pic that links to a GH profile, as per #71 |
@kungfuchicken I added a |
I really want as re-usable of a component as possible, and you delivered that. This lets us embrace the document-centric paradigm at the heart of MDX. The MDX file is the data source, and we're just enriching visualization of the data with a widget within the document. Simplifying in this paradigm means the data is stored in the MDX document. I pushed it a bit closer toward where i'm thinking about it, but there is still work to do. The tricky bit is the div that uses Ultimately the |
Updated about. md to connect all members connect to their GitHub profiles. The user profile pictures are picked from the local static files for those with available pictures, and the images are picked from their Github profiles.