Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Updated about to connect all members to their github profiles" #74

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rkarmuri
Copy link
Contributor

Updated about. md to connect all members connect to their GitHub profiles. The user profile pictures are picked from the local static files for those with available pictures, and the images are picked from their Github profiles.

@rkarmuri rkarmuri requested a review from kungfuchicken May 29, 2024 20:15
@rkarmuri
Copy link
Contributor Author

@kungfuchicken Please review the PR and let me know your comments. Thanks.

@kungfuchicken
Copy link
Collaborator

Is this part of the react component dev work and conversting the page to MDX? I would expect the component to handle the link as well as the profile image.

@rkarmuri
Copy link
Contributor Author

rkarmuri commented Jun 1, 2024

@kungfuchicken I created an MDX file that handles the profiles into several components. If available, the profile images are picked from the static folder; otherwise, the GitHub images are picked from the users' GitHub accounts. Please review.

@kungfuchicken
Copy link
Collaborator

This approach is functional, but will not scale or adapt well as roles change. Having a generic component for <ProfilePic /> will, and it will let us use the same component on project portfolio pages.

@kungfuchicken
Copy link
Collaborator

I also want to keep the text for each person in the MDX file rather than moving it to the component. I'd prefer the component focus on a single concern, creating a styled profile pic that links to a GH profile, as per #71

@rkarmuri
Copy link
Contributor Author

rkarmuri commented Jun 10, 2024

@kungfuchicken I added a <ProfilePic /> component. Please check if this works and let me know if we need to change anything.

@kungfuchicken
Copy link
Collaborator

I really want as re-usable of a component as possible, and you delivered that. This lets us embrace the document-centric paradigm at the heart of MDX. The MDX file is the data source, and we're just enriching visualization of the data with a widget within the document. Simplifying in this paradigm means the data is stored in the MDX document. I pushed it a bit closer toward where i'm thinking about it, but there is still work to do.

The tricky bit is the div that uses grid for layout. What I tried here is just one approach.

Ultimately the <ProfilePic> component might be used for all contributors, so we might want to rename some of the CSS classes to embrace wider reuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants