Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node): get test-assert.js working #15698

Merged
merged 71 commits into from
Jan 10, 2025
Merged

test(node): get test-assert.js working #15698

merged 71 commits into from
Jan 10, 2025

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Dec 11, 2024

What does this PR do?

  • Overhauls node:assert to better match node's behavior
  • Adds test-assert.js to the list of passing node test cases

Upstack from #15697

How did you verify your code works?

I ported node test cases.

@robobun
Copy link

robobun commented Dec 11, 2024

Updated 4:09 PM PT - Jan 9th, 2025

@DonIsaac, your commit 4b48543 has passed in #9321! 🎉


🧪   try this PR locally:

bunx bun-pr 15698

@DonIsaac DonIsaac marked this pull request as draft December 11, 2024 04:03
Base automatically changed from 12-10-build_trigger_cpp_build_when_generated_errorcode_files_change to 12-10-test_mock_node_test_module_in_node_test_harness December 11, 2024 04:36
@DonIsaac DonIsaac changed the base branch from 12-10-test_mock_node_test_module_in_node_test_harness to main December 11, 2024 04:56
@DonIsaac DonIsaac force-pushed the don/test/test-assert branch from 710cbf7 to bdd3d15 Compare December 11, 2024 04:56
@DonIsaac DonIsaac marked this pull request as ready for review December 12, 2024 06:20
@Jarred-Sumner Jarred-Sumner marked this pull request as draft December 12, 2024 09:51
Copy link
Member

@paperclover paperclover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall seems reasonable

src/bun.js/base.zig Show resolved Hide resolved
@DonIsaac DonIsaac requested a review from paperclover December 18, 2024 01:58
@DonIsaac DonIsaac enabled auto-merge January 9, 2025 02:10
@DonIsaac DonIsaac requested a review from Jarred-Sumner January 9, 2025 02:10
@DonIsaac DonIsaac added this pull request to the merge queue Jan 9, 2025
src/js/node/assert.ts Outdated Show resolved Hide resolved
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@DonIsaac
Copy link
Contributor Author

DonIsaac commented Jan 9, 2025

note: I had to move the node test bunfig.toml to the root directory. See #16289

@DonIsaac DonIsaac added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit 0372ca5 Jan 10, 2025
69 checks passed
@DonIsaac DonIsaac deleted the don/test/test-assert branch January 10, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants