-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(node): get test-assert.js
working
#15698
Merged
Merged
+4,548
−1,264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
12-10-build_trigger_cpp_build_when_generated_errorcode_files_change
to
12-10-test_mock_node_test_module_in_node_test_harness
December 11, 2024 04:36
DonIsaac
changed the base branch from
12-10-test_mock_node_test_module_in_node_test_harness
to
main
December 11, 2024 04:56
DonIsaac
force-pushed
the
don/test/test-assert
branch
from
December 11, 2024 04:56
710cbf7
to
bdd3d15
Compare
`Diff` still needs serializing. Blocked by #15742.
paperclover
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall seems reasonable
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 9, 2025
note: I had to move the node test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
node:assert
to better match node's behaviortest-assert.js
to the list of passing node test casesUpstack from #15697
How did you verify your code works?
I ported node test cases.