Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install): hoisting bugs causing flaky tests in CI #16267

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix(install): hoisting bugs causing flaky tests in CI #16267

wants to merge 9 commits into from

Conversation

dylan-conway
Copy link
Member

What does this PR do?

This fixes a bug causing resolving multiple versions of the same package to be out of order, resulting in an inconsistent amount of versions of the package to appear in the lockfile.

This also changes bun install to deduplicate more packages, similar to npm where having one copy of a package is prioritized.

fixes #13533
closes #1343

How did you verify your code works?

@robobun
Copy link

robobun commented Jan 9, 2025 •
edited
Loading

Updated 4:08 PM PT - Jan 9th, 2025

❌ @dylan-conway, your commit d2cef13 has 5 failures in #9320:

🧪   try this PR locally:

bunx bun-pr 16267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bun install routinely accumulates package duplication Deduplicate / dedupe command for bun install
2 participants
@dylan-conway @robobun