Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When prompting, use show_default as the default if its a string #2837

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

thejcannon
Copy link

@thejcannon thejcannon commented Jan 6, 2025

This PR just makes sure the default handed to .prompt is the show_default if its a string (to match the help).

fixes #2836

  • Add tests that demonstrate the correct behavior of the change. Tests
    should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.

@thejcannon
Copy link
Author

oh duh, this changes the default 🤦 . Gotta go deeper...

@thejcannon thejcannon marked this pull request as ready for review January 7, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show_default as a string isn't used in prompts as the default shown
1 participant