String dtype: disallow specifying the 'str' dtype with storage in [..] in string alias #60661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention was for the new default
"str"
dtype to not include the storage in the string alias, and so to also not allow constructing it that way (this is discussed in the PDEP).This is also implemented this way, as you can see when directly calling the extension dtype API:
However, when specifying this as a
dtype
argument in eg constructors (going throughpandas_dtype(...)
, which goes through the extension dtype registry), this "accidentally" kind of works, but gives an unexpected result:I think it is confusing that it does work in case of the pyarrow storage, but then does give a different dtype than what you would typically expect.
So I would rather just disallow this case (which is what this PR does), although this is a small breaking change for people currently using
dtype="str[pyarrow]"
to get the ArrowDtype.