Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix named colors support #4963

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix named colors support #4963

wants to merge 3 commits into from
+174 −25

Conversation

Ahm3dGI1
Copy link

@Ahm3dGI1 Ahm3dGI1 commented Jan 14, 2025 •
edited
Loading

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

This is the first PR of 3 PRs that address the problems mentioned in #4957 :

The changelog update and plotlyjs update are in the last PR #4964

This was referenced Jan 14, 2025
Open
Open
@gvwilson gvwilson added feature something new P2 considered for next cycle community community contribution labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ahm3dGI1 @gvwilson