Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward ref by default #4617

Open
wants to merge 2 commits into
base: v11-2
Choose a base branch
from
Open

Forward ref by default #4617

wants to merge 2 commits into from
+82 −84

Conversation

JoviDeCroock
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 22, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-8.16ms - +4.37ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +2% (-0.27ms - +0.31ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +3% (-0.50ms - +2.23ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +0% (-0.17ms - +0.04ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.93ms - +0.32ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +5% (-0.07ms - +0.10ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -3% - +3% (-1.17ms - +0.86ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +4% (-0.93ms - +1.49ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +4% (-0.35ms - +0.45ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +3% (-0.02ms - +0.04ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local940.50ms - 948.63ms-unsure 🔍
-1% - +0%
-8.16ms - +4.37ms
preact-main941.69ms - 951.23msunsure 🔍
-0% - +1%
-4.37ms - +8.16ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.20ms - 19.20ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main19.20ms - 19.20msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.49ms - 16.93ms-unsure 🔍
-2% - +2%
-0.27ms - +0.31ms
preact-main16.50ms - 16.88msunsure 🔍
-2% - +2%
-0.31ms - +0.27ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.51ms - 1.53ms-unsure 🔍
-1% - +1%
-0.01ms - +0.01ms
preact-main1.51ms - 1.52msunsure 🔍
-1% - +1%
-0.01ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.79ms - 71.54ms-unsure 🔍
-1% - +3%
-0.50ms - +2.23ms
preact-main68.76ms - 70.85msunsure 🔍
-3% - +1%
-2.23ms - +0.50ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local10.11ms - 10.64ms-unsure 🔍
-3% - +4%
-0.35ms - +0.45ms
preact-main10.03ms - 10.63msunsure 🔍
-4% - +3%
-0.45ms - +0.35ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.55ms - 16.61ms-unsure 🔍
-1% - +0%
-0.17ms - +0.04ms
preact-main16.54ms - 16.75msunsure 🔍
-0% - +1%
-0.04ms - +0.17ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.75ms - 3.76ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.75ms - 3.75msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4234

  • Commit: 554d0df

duration

VersionAvg timevs preact-localvs preact-main
preact-local67.86ms - 68.67ms-unsure 🔍
-1% - +0%
-0.93ms - +0.32ms
preact-main68.09ms - 69.05msunsure 🔍
-0% - +1%
-0.32ms - +0.93ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.96ms - 2.98ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-main2.97ms - 2.99msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local29.82ms - 30.33ms-unsure 🔍
-1% - +2%
-0.25ms - +0.48ms
preact-main29.70ms - 30.23msunsure 🔍
-2% - +1%
-0.48ms - +0.25ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.30ms - 34.39ms-unsure 🔍
-4% - +1%
-1.38ms - +0.20ms
preact-main33.86ms - 35.01msunsure 🔍
-1% - +4%
-0.20ms - +1.38ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.62ms - 26.06ms-unsure 🔍
-2% - +1%
-0.60ms - +0.28ms
preact-main25.61ms - 26.37msunsure 🔍
-1% - +2%
-0.28ms - +0.60ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.78ms - 26.98ms-unsure 🔍
-3% - +3%
-0.86ms - +0.92ms
preact-main25.70ms - 27.01msunsure 🔍
-3% - +3%
-0.92ms - +0.86ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local24.72ms - 25.89ms-unsure 🔍
-5% - +2%
-1.20ms - +0.60ms
preact-main24.92ms - 26.28msunsure 🔍
-2% - +5%
-0.60ms - +1.20ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.75ms - 22.16ms-faster ✔
0% - 3%
0.08ms - 0.74ms
preact-main22.10ms - 22.62msslower ❌
0% - 3%
0.08ms - 0.74ms		-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.96ms - 2.09ms-unsure 🔍
-3% - +5%
-0.07ms - +0.10ms
preact-main1.96ms - 2.06msunsure 🔍
-5% - +3%
-0.10ms - +0.07ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.11ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.11ms - 1.11msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.24ms - 34.48ms-unsure 🔍
-3% - +3%
-1.17ms - +0.86ms
preact-main33.21ms - 34.82msunsure 🔍
-3% - +3%
-0.86ms - +1.17ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.23ms - 1.27ms-unsure 🔍
-2% - +3%
-0.02ms - +0.04ms
preact-main1.23ms - 1.26msunsure 🔍
-3% - +2%
-0.04ms - +0.02ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.97ms - 34.77ms-unsure 🔍
-3% - +4%
-0.93ms - +1.49ms
preact-main32.78ms - 34.41msunsure 🔍
-4% - +3%
-1.49ms - +0.93ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.89ms - 2.91ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.89ms - 2.90msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 22, 2024 •
edited
Loading

Size Change: -74 B (-0.12%)

Total Size: 60.5 kB

Filename Size Change
compat/dist/compat.js 3.73 kB -46 B (-1.22%)
compat/dist/compat.module.js 3.66 kB -42 B (-1.14%)
compat/dist/compat.umd.js 3.79 kB -45 B (-1.17%)
debug/dist/debug.module.js 3.83 kB +1 B (+0.03%)
debug/dist/debug.umd.js 3.91 kB +1 B (+0.03%)
dist/preact.js 4.59 kB +8 B (+0.17%)
dist/preact.min.js 4.63 kB +4 B (+0.09%)
dist/preact.min.module.js 4.62 kB +5 B (+0.11%)
dist/preact.min.umd.js 4.66 kB +7 B (+0.15%)
dist/preact.module.js 4.62 kB +8 B (+0.17%)
dist/preact.umd.js 4.68 kB +13 B (+0.28%)
jsx-runtime/dist/jsxRuntime.js 981 B +3 B (+0.31%)
jsx-runtime/dist/jsxRuntime.module.js 956 B +4 B (+0.42%)
jsx-runtime/dist/jsxRuntime.umd.js 1.06 kB +5 B (+0.48%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.83 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
test-utils/dist/testUtils.js 451 B
test-utils/dist/testUtils.module.js 456 B
test-utils/dist/testUtils.umd.js 536 B

compressed-size-action

@JoviDeCroock JoviDeCroock force-pushed the forward-ref-by-default-2 branch from 55b8349 to cc2cc52 Compare December 22, 2024 10:26
@JoviDeCroock JoviDeCroock force-pushed the forward-ref-by-default-2 branch from e76a01a to 554d0df Compare December 22, 2024 12:37
@rschristian rschristian mentioned this pull request Dec 29, 2024
Open
rschristian
rschristian approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it

hooks/test/browser/useContext.test.js
@@ -174,7 +174,7 @@ describe('useContext', () => {
expect(unmountspy).not.to.be.called;
});

it('should only subscribe a component once', () => {
it.skip('should only subscribe a component once', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this skip still intended?

compat/test/browser/forwardRef.test.js
@@ -392,7 +392,7 @@ describe('forwardRef', () => {
expect(_ref.current).to.equal(scratch.firstChild);
});

it('should forward at diff time instead vnode-creation.', () => {
it.skip('should forward at diff time instead vnode-creation.', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I should just remove these skipped tests, will have a deeper look whether they could still matter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

@developit developit Awaiting requested review from developit

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoviDeCroock @rschristian