New branching model #34
Conversation
|
@MicTech Would you mind taking a look on this? :) |
|
@LeZuse I'd like to, but some better description would help ;) |
|
@MicTech sorry about that. I will create some explaining docs |
| echo "To activate the branch (auto updated revision with every branch deploy):" | ||
| echo "\t${CYAN}activate-branch --env=$ENV --branch=$BRANCH --notify$NC\n" | ||
| echo "To activate the commit:" | ||
| echo "\t${CYAN}activate-rev --env=$ENV --rev=$COMMIT --branch=$BRANCH --notify$NC\n" |
There was a problem hiding this comment.
We don't really allow that in the current version. We should change the wording a bit.
|
@MicTech I added a short readme section to explain the new branching model. Would you mind taking a look at it? Thanks |
| ## Activation | ||
| There are two steps to activate a deployed build. | ||
| 1. Activate branch: use `activate-branch --branch branchname` to activate this branch and set the current main build to the tip of this branch. All consecutive activations **inside this branch** will be automatically promoted as the main current build. | ||
| 2. Activate a revision: use `activate-rev --branch branchname --rev SHA` to activate a given SHA revision inside a given branch and set the revision as the main current build **if that branch has been previously activated**. |
There was a problem hiding this comment.
That's how the new setup works. You activate revs inside branches the same way you move a branch tip in Git.
There was a problem hiding this comment.
But you don't need information about the branch. There isn't a relation between branch and SHA.
| host: 'pub-redis-9999.us-east-1-1.2.ec2.garantiadata.com', | ||
| port: 9999, | ||
| db: 0, | ||
| host: 'pub-redis-9999.us-east-1-1.2.ec2.garantiadata.com', |
There was a problem hiding this comment.
Is this good idea to have those URL in the repository?
There was a problem hiding this comment.
Anything that's not supposed to be in the repo can be in the secrets.js file. I'd leave it up to the library user which parts they consider to be a secret :)
Adding true native support for deploy branches. Please see updated README for more info.