-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Draft autoscheduler #831
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #831 will degrade performances by 30.19%Comparing Summary
Benchmarks breakdown
|
3e5894a
to
219b11f
Compare
I feel we're implementing a lot of IR pass infrastructure which we don't really need -- IMHO it'd be better to define an IR and do it via egglog or MLIR. |
I think the only part of pass infrastructure rewritten here is |
egglog is overkill for a lot of Finch rewriting (especially since e-graph behavior is unbounded for the rules Finch uses, and deterministic matching works fine). The only time we might want to consider using Egglog would be for the theorem-proving rules. In the past, Jaeyeon has used Z3 for this to great success. However, the use of e-graphs should be considered a research topic for our initial rewriting. |
as for defining AST's, we might consider using the approach used in EXO: https://github.com/ChezJrk/asdl |
one last thing: I think the deferred node may change soon, all of the rest of this ast is stable but we may need to change deferred node. I'll try to remind y'all when I make the update. |
I personally really like that you can use the default python pattern matching here, it's a big benefit for readability and maintainability. I struggled for a long time to teach new users how to use the custom julia rewriting library because julia had no inbuilt pattern matching syntax. |
I will take a look at it! Here the requirement is that each AST class must be a Python |
I don't want to push too hard for ASDL,having each ast node be it's own class is simpler and easy to understand. |
WIP